X-Git-Url: http://git.nikiroo.be/?a=blobdiff_plain;f=src%2Fbe%2Fnikiroo%2Ffanfix%2Flibrary%2FRemoteLibraryServer.java;h=c2edeb3ecebeba71ee7149c118b9aaaab9f60512;hb=a5b424414ec03d932911cc2ea2be0d64fe25b0ef;hp=a40103c0b40f5d6e18995609b5731f5fda918a50;hpb=27eba894912a5b9a748d85c647f2f3a5b3a8a1c4;p=fanfix.git

diff --git a/src/be/nikiroo/fanfix/library/RemoteLibraryServer.java b/src/be/nikiroo/fanfix/library/RemoteLibraryServer.java
index a40103c..c2edeb3 100644
--- a/src/be/nikiroo/fanfix/library/RemoteLibraryServer.java
+++ b/src/be/nikiroo/fanfix/library/RemoteLibraryServer.java
@@ -6,6 +6,8 @@ import java.util.ArrayList;
 import java.util.Date;
 import java.util.List;
 
+import javax.net.ssl.SSLException;
+
 import be.nikiroo.fanfix.Instance;
 import be.nikiroo.fanfix.data.Chapter;
 import be.nikiroo.fanfix.data.MetaData;
@@ -24,14 +26,6 @@ import be.nikiroo.utils.serial.server.ServerObject;
  * The available commands are given as arrays of objects (first item is the
  * command, the rest are the arguments).
  * <p>
- * All commands, including PING, will first return a random value to you that
- * you must hash with your key and return before processing the rest; if the
- * value not correct, the connection will be closed.
- * <p>
- * BTW: this system <b>is by no means secure</b>. It is just slightly
- * obfuscated, and operate on clear text (because Google decided not to support
- * anonymous SSL exchanges on Android, and the main use case for this server is
- * Android).
  * <ul>
  * <li>PING: will return PONG if the key is accepted</li>
  * <li>GET_METADATA *: will return the metadata of all the stories in the
@@ -57,8 +51,6 @@ import be.nikiroo.utils.serial.server.ServerObject;
  * @author niki
  */
 public class RemoteLibraryServer extends ServerObject {
-	private final String key;
-
 	/**
 	 * Create a new remote server (will not be active until
 	 * {@link RemoteLibraryServer#start()} is called).
@@ -72,8 +64,7 @@ public class RemoteLibraryServer extends ServerObject {
 	 *             in case of I/O error
 	 */
 	public RemoteLibraryServer(String key, int port) throws IOException {
-		super("Fanfix remote library", port, false);
-		this.key = key;
+		super("Fanfix remote library", port, key);
 
 		setTraceHandler(Instance.getTraceHandler());
 	}
@@ -103,18 +94,6 @@ public class RemoteLibraryServer extends ServerObject {
 		}
 		System.out.println(trace);
 
-		// Authentication:
-		String random = StringUtils.getMd5Hash(Double.toString(Math.random()));
-		action.send(random);
-		String answer = "" + action.rec();
-
-		if (!answer.equals(RemoteLibrary.hashKey(key, random))) {
-			System.out.println("Key rejected.");
-			action.close();
-			return null;
-		}
-		//
-
 		Object rep = doRequest(action, command, args);
 
 		String rec = StringUtils.formatNumber(action.getBytesReceived()) + "b";
@@ -224,7 +203,11 @@ public class RemoteLibraryServer extends ServerObject {
 
 	@Override
 	protected void onError(Exception e) {
-		getTraceHandler().error(e);
+		if (e instanceof SSLException) {
+			System.out.println("[Client connection refused (bad key)]");
+		} else {
+			getTraceHandler().error(e);
+		}
 	}
 
 	/**