X-Git-Url: http://git.nikiroo.be/?a=blobdiff_plain;f=src%2Fbe%2Fnikiroo%2Fjvcard%2Fremote%2FServer.java;h=6cba0c33cbb09047ed09f4004f88266e9ee4193d;hb=d5260eeb873fcf2ef9855dedcd9e2a3a3a990582;hp=08091f6ea352e59cd96e5ec2a59032650eaea65c;hpb=e4444b0bc462544629d9e7e7ab62b96a4d9cab10;p=jvcard.git diff --git a/src/be/nikiroo/jvcard/remote/Server.java b/src/be/nikiroo/jvcard/remote/Server.java index 08091f6..6cba0c3 100644 --- a/src/be/nikiroo/jvcard/remote/Server.java +++ b/src/be/nikiroo/jvcard/remote/Server.java @@ -11,15 +11,16 @@ import java.util.HashMap; import java.util.LinkedList; import java.util.List; import java.util.Map; -import java.util.ResourceBundle; import be.nikiroo.jvcard.Card; import be.nikiroo.jvcard.Contact; import be.nikiroo.jvcard.Data; import be.nikiroo.jvcard.parsers.Format; import be.nikiroo.jvcard.parsers.Vcard21Parser; -import be.nikiroo.jvcard.resources.Bundles; -import be.nikiroo.jvcard.resources.StringUtils; +import be.nikiroo.jvcard.remote.SimpleSocket.BlockAppendable; +import be.nikiroo.jvcard.resources.RemoteBundle; +import be.nikiroo.jvcard.resources.RemotingOption; +import be.nikiroo.utils.StringUtils; /** * This class implements a small server that can listen for requests to @@ -33,7 +34,7 @@ import be.nikiroo.jvcard.resources.StringUtils; *

* * @author niki - * + * */ public class Server implements Runnable { private ServerSocket ss; @@ -58,9 +59,9 @@ public class Server implements Runnable { */ public Server(int port) throws IOException { this.port = port; - ResourceBundle bundle = Bundles.getBundle("remote"); + RemoteBundle bundle = new RemoteBundle(); try { - String dir = bundle.getString("SERVER_DATA_PATH"); + String dir = bundle.getString(RemotingOption.SERVER_DATA_PATH); dataDir = new File(dir); dataDir.mkdir(); @@ -130,8 +131,9 @@ public class Server implements Runnable { try { ss.open(false); - while (processCmd(ss)) - ; + while (processCmd(ss)) { + // nothing to do: process the command + } } catch (IOException e) { e.printStackTrace(); @@ -236,8 +238,9 @@ public class Server implements Runnable { try { s.sendLine(StringUtils.fromTime(file.lastModified())); - while (processLockedCmd(s, name)) - ; + while (processLockedCmd(s, name)) { + // nothing to do: process the command + } } catch (InvalidParameterException e) { System.err .println("Unsupported command received from a client connection, closing it: " @@ -323,7 +326,7 @@ public class Server implements Runnable { switch (command) { case GET_CARD: { - s.sendBlock(doGetCard(name)); + sendCardBlock(s, name); break; } case POST_CARD: { @@ -340,8 +343,9 @@ public class Server implements Runnable { } else { Card card = new Card(vcf, Format.VCard21); try { - while (processContactCmd(s, card)) - ; + while (processContactCmd(s, card)) { + // nothing to do: process the command + } card.save(); s.sendLine(StringUtils.fromTime(card.getLastModified())); } catch (InvalidParameterException e) { @@ -405,10 +409,13 @@ public class Server implements Runnable { switch (command) { case GET_CONTACT: { Contact contact = card.getById(cmd.getParam()); - if (contact != null) - s.sendBlock(Vcard21Parser.toStrings(contact, -1)); - else + if (contact != null) { + BlockAppendable app = s.createBlockAppendable(); + Vcard21Parser.write(app, contact, -1); + app.close(); + } else { s.sendBlock(); + } break; } case POST_CONTACT: { @@ -431,8 +438,9 @@ public class Server implements Runnable { throw new InvalidParameterException( "Cannot find contact to modify for UID: " + uid); } - while (processDataCmd(s, contact)) - ; + while (processDataCmd(s, contact)) { + // nothing to do: process the command + } break; } case DELETE_CONTACT: { @@ -453,7 +461,7 @@ public class Server implements Runnable { if (contact == null) { s.sendBlock(); } else { - s.sendLine(contact.getContentState()); + s.sendLine(contact.getContentState(true)); } break; } @@ -464,7 +472,8 @@ public class Server implements Runnable { || (contact.getPreferredDataValue("FN") + contact .getPreferredDataValue("N")).toLowerCase() .contains(cmd.getParam().toLowerCase())) { - s.send(contact.getContentState() + " " + contact.getId()); + s.send(contact.getContentState(true) + " " + + contact.getId()); } } s.sendBlock(); @@ -515,9 +524,9 @@ public class Server implements Runnable { case GET_DATA: { for (Data data : contact) { if (data.getName().equals(cmd.getParam())) { - for (String line : Vcard21Parser.toStrings(data)) { - s.send(line); - } + BlockAppendable app = s.createBlockAppendable(); + Vcard21Parser.write(app, data); + // note: we do NOT close 'app', since it would send an EOB } } s.sendBlock(); @@ -527,7 +536,7 @@ public class Server implements Runnable { String cstate = cmd.getParam(); Data data = null; for (Data d : contact) { - if (cstate.equals(d.getContentState())) + if (cstate.equals(d.getContentState(true))) data = d; } @@ -543,7 +552,7 @@ public class Server implements Runnable { String cstate = cmd.getParam(); Data data = null; for (Data d : contact) { - if (cstate.equals(d.getContentState())) + if (cstate.equals(d.getContentState(true))) data = d; } @@ -559,7 +568,7 @@ public class Server implements Runnable { case HASH_DATA: { for (Data data : contact) { if (data.getId().equals(cmd.getParam())) { - s.send(data.getContentState()); + s.send(data.getContentState(true)); } } s.sendBlock(); @@ -571,7 +580,7 @@ public class Server implements Runnable { || cmd.getParam().length() == 0 || data.getName().toLowerCase() .contains(cmd.getParam().toLowerCase())) { - s.send(data.getContentState() + " " + data.getName()); + s.send(data.getContentState(true) + " " + data.getName()); } } s.sendBlock(); @@ -601,20 +610,19 @@ public class Server implements Runnable { * @throws IOException * in case of error */ - private List doGetCard(String name) throws IOException { - List lines = new LinkedList(); - + private void sendCardBlock(SimpleSocket s, String name) throws IOException { File vcf = getFile(name); + BlockAppendable app = s.createBlockAppendable(); if (vcf != null && vcf.exists()) { Card card = new Card(vcf, Format.VCard21); // timestamp + data - lines.add(StringUtils.fromTime(card.getLastModified())); - lines.addAll(Vcard21Parser.toStrings(card)); + app.append(StringUtils.fromTime(card.getLastModified()) + "\r\n"); + Vcard21Parser.write(app, card); } - return lines; + app.close(); } /**