From e61669f9cb4d4ab1180e56785842091dbb8feb9c Mon Sep 17 00:00:00 2001 From: Niki Roo Date: Sat, 4 May 2019 19:20:52 +0200 Subject: [PATCH] improve CryptUtils perf --- src/be/nikiroo/utils/CryptUtils.java | 30 +++++++++------------------- 1 file changed, 9 insertions(+), 21 deletions(-) diff --git a/src/be/nikiroo/utils/CryptUtils.java b/src/be/nikiroo/utils/CryptUtils.java index 9ef91015..ba9e7002 100644 --- a/src/be/nikiroo/utils/CryptUtils.java +++ b/src/be/nikiroo/utils/CryptUtils.java @@ -4,16 +4,13 @@ import java.io.IOException; import java.io.InputStream; import java.io.OutputStream; import java.io.UnsupportedEncodingException; -import java.security.InvalidAlgorithmParameterException; import java.security.InvalidKeyException; -import java.security.NoSuchAlgorithmException; import javax.crypto.BadPaddingException; import javax.crypto.Cipher; import javax.crypto.CipherInputStream; import javax.crypto.CipherOutputStream; import javax.crypto.IllegalBlockSizeException; -import javax.crypto.NoSuchPaddingException; import javax.crypto.SecretKey; import javax.crypto.spec.IvParameterSpec; import javax.crypto.spec.SecretKeySpec; @@ -31,12 +28,16 @@ import be.nikiroo.utils.streams.Base64OutputStream; *
  • The streams are independent and thus parallel
  • * *

    - * Do not assume it is actually secure until you checked the code... + * Do not assume it is actually secure, it is actually not. + *

    + * It just here to offer a more-or-less protected exchange of data because + * anonymous and self-signed certificates backed SSL is against Google wishes + * (so, don't even try, they own Internet). * * @author niki */ public class CryptUtils { - static private final String AES_NAME = "AES/CFB8/NoPadding"; + static private final String AES_NAME = "AES/CFB128/NoPadding"; private Cipher ecipher; private Cipher dcipher; @@ -236,24 +237,11 @@ public class CryptUtils { Cipher cipher = Cipher.getInstance(AES_NAME); cipher.init(mode, key, ivspec); return cipher; - } catch (NoSuchAlgorithmException e) { - // Every implementation of the Java platform is required to support - // this standard Cipher transformation with 128 bits keys - e.printStackTrace(); - } catch (NoSuchPaddingException e) { - // Every implementation of the Java platform is required to support - // this standard Cipher transformation with 128 bits keys - e.printStackTrace(); - } catch (InvalidKeyException e) { - // Every implementation of the Java platform is required to support - // this standard Cipher transformation with 128 bits keys - e.printStackTrace(); - } catch (InvalidAlgorithmParameterException e) { - // Woops? + } catch (Exception e) { e.printStackTrace(); + throw new RuntimeException( + "Cannot initialize encryption sub-system", e); } - - return null; } /** -- 2.27.0