Bundle: fix memory leak at init/reset

[fanfix.git] / ui / ZoomBox.java

diff --git a/ui/ZoomBox.java b/ui/ZoomBox.java
index 44338d9ffde0b2375095859f4a587e0167520dfa..a8f96095928a8a9dba8a92fde829f6e31019f817 100644 (file)
--- a/ui/ZoomBox.java
+++ b/ui/ZoomBox.java
@@ -3,11 +3,13 @@ package be.nikiroo.utils.ui;
 import java.awt.event.ActionEvent;
 import java.awt.event.ActionListener;
 
+import javax.swing.BorderFactory;
 import javax.swing.BoxLayout;
 import javax.swing.DefaultComboBoxModel;
 import javax.swing.Icon;
 import javax.swing.JButton;
 import javax.swing.JComboBox;
+import javax.swing.JLabel;
 
 /**
  * A small panel that let you choose a zoom level or an actual zoom value (when
@@ -87,6 +89,7 @@ public class ZoomBox extends ListenerPanel {
        private JButton zoomOut;
        private JButton snapWidth;
        private JButton snapHeight;
+       private JLabel zoomLabel;
 
        @SuppressWarnings("rawtypes") // JComboBox<?> is not java 1.6 compatible
        private JComboBox zoombox;
@@ -175,6 +178,9 @@ public class ZoomBox extends ListenerPanel {
                        }
                });
 
+               zoomLabel = new JLabel();
+               zoomLabel.setBorder(BorderFactory.createEmptyBorder(10, 10, 0, 0));
+
                setIcons(null, null, null, null);
                setOrientation(vertical);
        }
@@ -182,7 +188,7 @@ public class ZoomBox extends ListenerPanel {
        /**
         * The zoom level.
         * <p>
-        * It usually returns 1 (default value), the value you passed yourself or 0
+        * It usually returns 1 (default value), the value you passed yourself or 1
         * (a snap to width or snap to height was asked by the user).
         * <p>
         * Will cause a fire event if needed.
@@ -401,9 +407,13 @@ public class ZoomBox extends ListenerPanel {
         *            the zoom level
         */
        private void doSetZoom(double zoom) {
-               if (snapMode == null) {
-                       zoomBoxModel.setSelectedItem(
-                                       Integer.toString((int) Math.round(zoom * 100)) + " %");
+               if (zoom > 0) {
+                       String zoomStr = Integer.toString((int) Math.round(zoom * 100))
+                                       + " %";
+                       zoomLabel.setText(zoomStr);
+                       if (snapMode == null) {
+                               zoomBoxModel.setSelectedItem(zoomStr);
+                       }
                }
 
                this.zoom = zoom;
@@ -417,8 +427,11 @@ public class ZoomBox extends ListenerPanel {
         */
        private void doSetSnapMode(Boolean snapToWidth) {
                if (snapToWidth == null) {
-                       zoomBoxModel.setSelectedItem(
-                                       Integer.toString((int) Math.round(zoom * 100)) + " %");
+                       String zoomStr = Integer.toString((int) Math.round(zoom * 100))
+                                       + " %";
+                       if (zoom > 0) {
+                               zoomBoxModel.setSelectedItem(zoomStr);
+                       }
                } else {
                        for (ZoomLevel level : ZoomLevel.values()) {
                                if (level.getSnapToWidth() == snapToWidth) {
@@ -441,14 +454,17 @@ public class ZoomBox extends ListenerPanel {
                        this.removeAll();
                        setLayout(layout);
 
-                       this.add(zoomIn);
                        if (vertical || small) {
+                               this.add(zoomIn);
                                this.add(snapWidth);
                                this.add(snapHeight);
+                               this.add(zoomOut);
+                               this.add(zoomLabel);
                        } else {
+                               this.add(zoomIn);
                                this.add(zoombox);
+                               this.add(zoomOut);
                        }
-                       this.add(zoomOut);
 
                        this.revalidate();
                        this.repaint();